Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Change TraceQueryParams to accept typed attributes #6780

Merged
merged 5 commits into from
Feb 27, 2025

Conversation

mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Feb 27, 2025

Which problem is this PR solving?

Description of the changes

How was this change tested?

  • CI

Checklist

Signed-off-by: Mahad Zaryab <[email protected]>
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.04%. Comparing base (1c99aa0) to head (98a99eb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6780      +/-   ##
==========================================
- Coverage   96.07%   96.04%   -0.03%     
==========================================
  Files         363      364       +1     
  Lines       20677    20690      +13     
==========================================
+ Hits        19865    19872       +7     
- Misses        620      624       +4     
- Partials      192      194       +2     
Flag Coverage Δ
badger_v1 9.81% <50.00%> (+0.05%) ⬆️
badger_v2 1.89% <43.75%> (+0.06%) ⬆️
cassandra-4.x-v1-manual 14.86% <50.00%> (+0.05%) ⬆️
cassandra-4.x-v2-auto 1.88% <43.75%> (+0.06%) ⬆️
cassandra-4.x-v2-manual 1.88% <43.75%> (+0.06%) ⬆️
cassandra-5.x-v1-manual 14.86% <50.00%> (+0.05%) ⬆️
cassandra-5.x-v2-auto 1.88% <43.75%> (+0.06%) ⬆️
cassandra-5.x-v2-manual 1.88% <43.75%> (+0.06%) ⬆️
elasticsearch-6.x-v1 19.19% <50.00%> (+0.04%) ⬆️
elasticsearch-7.x-v1 19.27% <50.00%> (+0.04%) ⬆️
elasticsearch-8.x-v1 19.44% <50.00%> (+0.04%) ⬆️
elasticsearch-8.x-v2 1.89% <43.75%> (+0.06%) ⬆️
grpc_v1 10.86% <50.00%> (+0.05%) ⬆️
grpc_v2 7.86% <43.75%> (+0.06%) ⬆️
kafka-3.x-v1 10.11% <0.00%> (-0.02%) ⬇️
kafka-3.x-v2 1.89% <43.75%> (+0.06%) ⬆️
memory_v2 1.89% <43.75%> (+0.06%) ⬆️
opensearch-1.x-v1 19.32% <50.00%> (+0.04%) ⬆️
opensearch-2.x-v1 19.32% <50.00%> (+0.04%) ⬆️
opensearch-2.x-v2 1.89% <43.75%> (+0.06%) ⬆️
tailsampling-processor 0.48% <0.00%> (-0.01%) ⬇️
unittests 94.93% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1 mahadzaryab1 changed the title [WIP][refactor] Change TraceQueryParameters to accept typed attributes [refactor] Change TraceQueryParameters to accept typed attributes Feb 27, 2025
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review February 27, 2025 03:53
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner February 27, 2025 03:53
@dosubot dosubot bot added the area/storage label Feb 27, 2025
@mahadzaryab1 mahadzaryab1 changed the title [refactor] Change TraceQueryParameters to accept typed attributes [refactor] Change TraceQueryParams to accept typed attributes Feb 27, 2025
@mahadzaryab1 mahadzaryab1 added this pull request to the merge queue Feb 27, 2025
Merged via the queue into jaegertracing:main with commit 043b826 Feb 27, 2025
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants