use curl #2
Closed
use curl #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2018
jaggedsoft
pushed a commit
that referenced
this pull request
Feb 5, 2018
Merge from development branch
|
Why did you close this? |
|
I'm wondering the same thing. Since it was closed right away, I didn't ever see it |
|
I wasn't sure if you were partial to the file_get_contents, would prefer curl also. I'll send a patch tomorrow maybe 😊 |
|
Nope, it's nice because it doesn't need an extra dependency, but we're using composer so that shouldn't matter. I'm planning on a complete rework of this library once I have time. It can be made to be much easier. |
|
Thanks! |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.