Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igraph dependency now optional #17

Merged
merged 3 commits into from
Feb 3, 2020
Merged

igraph dependency now optional #17

merged 3 commits into from
Feb 3, 2020

Conversation

jajcayn
Copy link
Owner

@jajcayn jajcayn commented Feb 3, 2020

  • divide requirements to optional and basic
  • add notes to README
  • import igraph within plotting function (lazy import) instead of a global one
  • when igraph not installed, skip ternary tree plotting test
  • bump version to 0.3

@jajcayn jajcayn self-assigned this Feb 3, 2020
@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files           5        5           
  Lines         585      585           
=======================================
  Hits          562      562           
  Misses         23       23
Impacted Files Coverage Δ
gpso/plotting.py 93.9% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51b8eb9...2d1fdf6. Read the comment docs.

@jajcayn jajcayn merged commit fac6ca3 into master Feb 3, 2020
@jajcayn jajcayn deleted the feature/igraph_optional branch February 3, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant