Jakarta persistence module proposal #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Otavio Santana <[email protected]>
Signed-off-by: Otavio Santana <[email protected]>
Signed-off-by: Otavio Santana <[email protected]>
Signed-off-by: Otavio Santana <[email protected]>
otaviojava
commented
Feb 24, 2024
| * @param <T> the type of the primary entity class of the repository. | ||
| * @param <K> the type of the Id attribute of the primary entity. | ||
| */ | ||
| public interface JakartaPersistenceRepository <T, K> extends DataRepository<T, K> { |
There was a problem hiding this comment.
Once we agree with persistenceI belive the JakartaPersistence might be fine.
Open for suggestion, I am not good at name proposals
otaviojava
commented
Feb 24, 2024
| public interface JakartaPersistenceRepository <T, K> extends DataRepository<T, K> { | ||
|
|
||
| @Find | ||
| T find(K id); |
There was a problem hiding this comment.
It requires the documentation, but IMHO, we can do it in another PR. It has a lot of changes here.
|
Otavio - before you get too far along this path, this is not something that we can get into version 1.0. We can look at additional repositories in the next version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Based on this discussion: #477