Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute is missing type #494

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Attribute is missing type #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion api/src/main/java/jakarta/data/metamodel/Attribute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@

/**
* Represents an entity attribute in the {@link StaticMetamodel}.
*
* @param <T> entity class of the static metamodel.
*/
public interface Attribute {
public interface Attribute<T> {
/**
* Obtain the entity attribute name, suitable for use wherever the specification requires
* an entity attribute name. For example, as the parameter to {@link Sort#asc(String)}.
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/jakarta/data/metamodel/SortableAttribute.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
*
* @param <T> entity class of the static metamodel.
*/
public interface SortableAttribute<T> extends Attribute {
public interface SortableAttribute<T> extends Attribute<T> {

/**
* Obtain a request for an ascending {@link Sort} based on the entity attribute.
Expand Down
2 changes: 1 addition & 1 deletion tck/src/main/java/ee/jakarta/tck/data/framework/read/only/_AsciiChar.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class _AsciiChar {

public static volatile SortableAttribute<AsciiCharacter> id;
public static volatile TextAttribute<AsciiCharacter> hexadecimal;
public static volatile Attribute isControl; // user decided it didn't care about sorting for this one
public static volatile Attribute<AsciiCharacter> isControl; // user decided it didn't care about sorting for this one
public static volatile SortableAttribute<AsciiCharacter> numericValue;
public static volatile TextAttribute<AsciiCharacter> thisCharacter;

Expand Down