Fix tck and javadoc errors and mistake with future compatibilty #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[first commit] The TCK needs to line up with the API change where Delete methods cannot return boolean.
[second commit] Also, this fixes some minor JavaDoc errors in that area that were preventing the project from building.
[third commit] Also, I realize that I got things backwards in trying to arrange for future compatibility. The way to give ourselves the flexibility of additional usage patterns of Delete/Update in the future is to disallow other usage now. Then we will not be making a breaking change when we expand it to include the additional pattern. I added updates to get rid of a few of the statements I mistakenly asked for previously.