Update API returning Optional instead of Null #497
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Otavio Santana <[email protected]>
Signed-off-by: Otavio Santana <[email protected]>
Signed-off-by: Otavio Santana <[email protected]>
Merged
|
@njr-11 don't forget of review this one. |
otaviojava
commented
Mar 1, 2024
| * | ||
| * @return a request for the next page. | ||
| */ | ||
| PageRequest<T> nextPageRequest(); | ||
| Optional<PageRequest<T>> nextPageRequest(); |
There was a problem hiding this comment.
@njr-11 it still require this validation.
There was a problem hiding this comment.
That's only because the other pull missed the part about raising an exception from nextPageRequest/previousPageRequest instead of returning null. I can make sure that gets included when updating the TCK to cover hasNext/hasPrevious. Then this will follow the pattern of java.util.Iterator and java.util.ListIterator where you must check hasNext (or hasPrevious) before requesting the next/previous
|
@otaviojava can we close this? With other changes that have gone in, it is no longer possible to get a null from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Once we are using optional when the return might be null, such as, it would be great to keep the consistency here as well.