Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rationalize the supported query return types #511

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

gavinking
Copy link
Contributor

See #503. Reactions?

Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks consistent with what we were discussing.
I would say that Streamable also should be deleted from Jakarta Data if there isn't any requirement to support returning it, but that probably needs to be deleted separately because first we will need to make the TCK stop using it.

@gavinking
Copy link
Contributor Author

I would say that Streamable also should be deleted from Jakarta Data if there isn't any requirement to support returning it, but that probably needs to be deleted separately because first we will need to make the TCK stop using it.

Right, and also we could do it as part of removing Slicey things, if that's the direction we want to go in.

@@ -31,7 +31,8 @@
* <p>The {@code Find} annotation indicates that the annotated repository method executes a query to retrieve entities
* based on specified parameters. The method parameters must match the types and names of the corresponding fields of
* the entity being queried. There is no specific naming convention for methods annotated with {@code @Find}; they may
* be named arbitrarily, and their names do not carry any specific semantic meaning.
* be named arbitrarily, and their names do not carry any specific semantic meaning. The method return type identifies
* the entity type returned by the query.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added this line, which was missing from the jdoc.

@gavinking gavinking marked this pull request as ready for review March 1, 2024 08:03
@otaviojava otaviojava merged commit 90a0edd into jakartaee:main Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants