TCK tests using return types that no longer correspond to spec requirements #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amable to List Signed-off-by: Nathan Rauh <[email protected]>
…orted by the spec
otaviojava
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCK tests need to avoid using repository method return types like Iterable, LinkedList, ArrayList, and so forth which are no longer required by the Jakarta Data specification/JavaDoc.
This pull updates these TCK repository methods to switch to return types that the spec requires.
Also, there is a TCK test that was commented out due to having the Streamable return type, which was also removed. I switched this to use a return type of List, which is a return type that is required to be supported by the spec, and re-enabled that test after renaming it from testStreamable to something more appropriate.