PageRecord computes incorrect moreResults when totalElements unknown #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
reviewed
Mar 6, 2024
| public PageRecord(PageRequest<T> pageRequest, List<T> content, long totalElements) { | ||
| this( pageRequest, content, totalElements, | ||
| content.size() == pageRequest.size() | ||
| && totalElements > pageRequest.size() * pageRequest.page() ); | ||
| && (totalElements < 0 | ||
| || totalElements > pageRequest.size() * pageRequest.page() )); |
There was a problem hiding this comment.
Yeah that's definitely what I intended it to say. Not quite sure how I managed to mess that up.
gavinking
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this warning when building the project,
When I looked into correcting it by adding the missing JavaDoc, I realized the documentation would need to state how the constructor computes the moreResults record component and started to do so, but then realized the logic is incorrect for the path where the
totalElementsis unknown, always computing afalsevalue formoreResults. I added a unit test to demonstrate the error and corrected the code.Also, I'm fixing a minor display issue in the return types table where the alternating highlighting is out of sync for the last entry of the table, causing it to appear like the information applies to the last two entries lumped together as one.