Keep record style at the CursoredPage #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Otavio Santana <[email protected]>
gavinking
approved these changes
Mar 17, 2024
njr-11
reviewed
Mar 18, 2024
| @@ -154,7 +154,7 @@ public interface CursoredPage<T> extends Page<T> { | |||
| * @param index position (0 is first) of a result on the page. | |||
| * @return cursor for key values at the specified position. | |||
| */ | |||
| PageRequest.Cursor getCursor(int index); | |||
| PageRequest.Cursor cursor(int index); | |||
There was a problem hiding this comment.
This is not a record style accessor. It accepts a parameter value.
There was a problem hiding this comment.
That is a good point, but it still accesses info.
IMHO: It should keep without "get" as the other ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.