TCK has outdated expectation for exception type #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njr-11
force-pushed
the
tck-traps-for-outdated-exception-type
branch
from
d2b414f to
c10d037
Compare
njr-11
commented
Mar 26, 2024
| @@ -41,7 +41,7 @@ public interface PositiveIntegers extends BasicRepository<NaturalNumber, Long> { | |||
|
|
|||
| boolean existsByIdGreaterThan(Long number); | |||
|
|
|||
| CursoredPage<NaturalNumber> findByFloorOfSquareRootNotAndIdLessThanOrderByBitsRequiredDesc(long excludeSqrt, | |||
| CursoredPage<NaturalNumber> findByFloorOfSquareRootNotAndIdLessThanOrderByNumBitsRequiredDesc(long excludeSqrt, | |||
There was a problem hiding this comment.
Query by Method Name was using incorrect field name that did not match the entity.
Comment on lines
+706
to
+711
| // 32 requires 6 bits | ||
| // 25, 26, 27, 28, 29, 30, 31 requires 5 bits | ||
| // 8, 9, 10, 11, 12, 13, 14, 15 requires 4 bits | ||
| // 4, 5, 6, 7, 8 requires 3 bits | ||
| // 2, 3 requires 2 bits | ||
| // 1 requires 1 bit |
There was a problem hiding this comment.
This test case was trying to assert ordering by square root descending but it actually asks for sorting by number of bits required descending.
| // is not capable of cursor-based pagination. | ||
| return; | ||
| } | ||
|
|
||
| assertEquals(Arrays.toString(new Long[] { 10L, 9L, // 4 bits required, square root rounds down to 3 | ||
| 7L, 6L, 5L, 4L, // 3 bits required, square root rounds down to 2 | ||
| 3L, 2L // 2 bits required, square root rounds down to 1 | ||
| 3L // 2 bits required, square root rounds down to 1 |
There was a problem hiding this comment.
This test case asks for pages of size 7, but mistakenly tries to assert that this page will have 8 elements.
gavinking
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating exceptions that are trapped in the TCK, I found a bunch of places where the TCK is trapping for
MappingExceptionthat should have been updated when the specification was switched toUnsupportedOperationException. Fortunately, these are all cases where the requirement for the exception is at run time only because it requires finding out information from the database. Otherwise we would have a problem testing the behavior at all in these cases.