Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove TCK test for removed features of query by method name #628

Merged
merged 1 commit into from
Apr 3, 2024
Merged

remove TCK test for removed features of query by method name #628

merged 1 commit into from
Apr 3, 2024

Conversation

gavinking
Copy link
Contributor

we removed the Contains and Empty operators from query by method name

njr-11
njr-11 reviewed Apr 3, 2024
View reviewed changes
Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with removing these because they aren't in the spec anymore, but we also need to remove the test methods testContainsInCollection and testEmpty that invoke these methods.

@gavinking gavinking force-pushed the kill-another-test branch from 6d74a32 to fadd9aa Compare April 3, 2024 11:51
@gavinking
Copy link
Contributor Author

Ooops.🤭

@otaviojava otaviojava merged commit c74a3c6 into jakartaee:main Apr 3, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njr-11 njr-11 njr-11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavinking @njr-11 @otaviojava