Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract method query in a single asciidoc #632

Merged
merged 4 commits into from
Apr 3, 2024
Merged

Conversation

otaviojava
Copy link
Contributor

Changes

  • Create a single page at method-query.asciidoc


Refer to the Jakarta Data module Javadoc section on "Return Types for Repository Methods" for a listing of valid return types for methods using Query by Method Name.

=== Special Parameters for Limits, Sorting, and Pagination
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section applies to various patterns in Jakarta Data and is not unique to Query by Method Name. It should remain in the main document instead of being moved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njr-11 , done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, I'm specifically referring to the section starting from

=== Special Parameters for Limits, Sorting, and Pagination

Github also shows some prior lines on my comment, but I am not referring to those preceding lines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njr-11 This section is on the repository

Screenshot 2024-04-03 at 17 44 34

Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This moves Query by Method Name spec doc to a new file from the development side. I think Gavin also wants it in a separate PDF, but this is a good step in that direction.

@otaviojava
Copy link
Contributor Author

This moves Query by Method Name spec doc to a new file from the development side. I think Gavin also wants it in a separate PDF, but this is a good step in that direction.

We can do a PDF from a single file, there is no issue on it.

Copy link
Contributor

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @otaviojava

@otaviojava otaviojava merged commit 44d72be into main Apr 3, 2024
3 checks passed
@otaviojava otaviojava deleted the extract-method-query branch April 3, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants