Remove Sort at PageRequest

[otaviojava]

Changes

The goal is to define single responsibility at PageRequest

⚠️ I saw the PRs around specification and TCK, thus, if you don't mind. I would break it into small pieces; thus, once it is merged, I will work on the TCK and the spec.

[otaviojava]

@gavinking @njr-11

[gavinking]

I say go ahead and merge it, though I think we should all review all the related javadoc again after the merge.

[gavinking]

I think we should all review all the related javadoc again after the merge.

(Just because I think it's really hard to catch everything.)

[njr-11]

I say go ahead and merge it, though I think we should all review all the related javadoc again after the merge.

I had only just started looking at it and already noticed missed places in JavaDoc/examples

[otaviojava]

@njr-11 @gavinking merged, I will work to fix the TCK.

[KyleAure]

Uff. I don't think this should have been merged with compile time errors. Now nothing can be developed or delivered until this is resolved. @otaviojava @gavinking
https://github.com/jakartaee/data/actions/runs/8556638994/job/23446947613

[njr-11]

Uff. I don't think this should have been merged with compile time errors.

I totally agree. I tried making a comment that I had only even just started reviewing it and was seeing issues. If it weren't so late in the cycle I'd say we should revert it, but that would only cost more time.

I see that Gavin already fixed one of the compile errors in the API. I'll look into fixing the others in the TCK

[gavinking]

Yeah I messed up when I said "go ahead and merge it", I didn't realize there were compilation errors.

[otaviojava]

Uff. I don't think this should have been merged with compile time errors. Now nothing can be developed or delivered until this is resolved. @otaviojava @gavinking https://github.com/jakartaee/data/actions/runs/8556638994/job/23446947613

It was my mistake, sorry everyone.

[otaviojava]

I am working to fix it now.

To be honest, I expected it to be faster; I did not realize that the IDE does not work properly here.

[otaviojava]

Uff. I don't think this should have been merged with compile time errors.

I totally agree. I tried making a comment that I had only even just started reviewing it and was seeing issues. If it weren't so late in the cycle I'd say we should revert it, but that would only cost more time.

I see that Gavin already fixed one of the compile errors in the API. I'll look into fixing the others in the TCK

ops, I saw that you will work on the tck.
I will hold it.