Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QBN issue in CDI tests #649

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Conversation

KyleAure
Copy link
Contributor

@KyleAure KyleAure commented Apr 4, 2024

DRAFT - signatures need to be updated with jakarta.data.spi package, but a compile time failure was merged.

@KyleAure KyleAure self-assigned this Apr 4, 2024
@KyleAure KyleAure added the test Something test-related label Apr 4, 2024
@KyleAure KyleAure force-pushed the 640-QBN-tck-issue branch from 58c555c to b836d77 Compare April 4, 2024 19:35
@KyleAure KyleAure force-pushed the 640-QBN-tck-issue branch from b836d77 to 588989e Compare April 4, 2024 20:33
@KyleAure KyleAure marked this pull request as ready for review April 4, 2024 20:34
@gavinking
Copy link
Contributor

Nice, that looks better, thanks.

@otaviojava otaviojava merged commit 967f817 into jakartaee:main Apr 5, 2024
3 checks passed
@KyleAure KyleAure deleted the 640-QBN-tck-issue branch April 5, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Something test-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TCK Challenge]: ExtensionTests#testDataProviderWithBuildCompatibleExtension conflicts with QBN
4 participants