fix incorrect implementation of PageRequest.page() #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
force-pushed
the
pagerequest.page
branch
from
f9bfc03 to
e055871
Compare
gavinking
commented
Apr 7, 2024
| } | ||
| return s.append("}").toString(); | ||
| } | ||
|
|
||
| @Override | ||
| public PageRequest page(long pageNumber) { | ||
| return new Pagination(pageNumber, size, mode, type, requestTotal); | ||
| return new Pagination(pageNumber, size, Mode.OFFSET, null, requestTotal); |
There was a problem hiding this comment.
Here is the important change.
gavinking
force-pushed
the
pagerequest.page
branch
from
e055871 to
43c2562
Compare
this operation should not propagate the Cursor value
gavinking
force-pushed
the
pagerequest.page
branch
from
43c2562 to
a70e9cc
Compare
|
Actually I'm just now realizing that there's a huge confusion about what these copying mutators actually mean for this class. Currently, a We need to split some of these operations onto a |
|
Closing this in favor of #672 because there is a much deeper problem here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this operation should not propagate the
Cursorvalue