PageRequest.page(num) method can cause wrong usage #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I said, I like this as the first step, but it only fixes some problems. The specialization will solve it entirely, but I know it has an impact. |
…f PageRequest Signed-off-by: Nathan Rauh <[email protected]>
Signed-off-by: Nathan Rauh <[email protected]>
njr-11
force-pushed
the
672-pagerequest-page-method-can-cause-wrong-usage
branch
from
c36e83c to
26ffc6f
Compare
It is not clear to me what problem the specialization solves. I asked Gavin for more clarification under #672 and came up with this to address what he identified. |
|
In term of impact, I prefer this one |
|
OK, this looks much better. |
gavinking
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #672
This adds onto the change to remove next()/previous() (first commit) and also removes page(number) from PageRequest (second commit). All of these methods can mislead applications into writing code that causes wrong behavior.