Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use web archive instead of java archive for standalone #707

Merged
merged 3 commits into from
Apr 17, 2024
Merged

Use web archive instead of java archive for standalone #707

merged 3 commits into from
Apr 17, 2024

Conversation

KyleAure
Copy link
Contributor

@KyleAure KyleAure commented Apr 17, 2024 •
edited
Loading

Fixes #705

  • Packages standalone tests as .war instead of .jar. When running in SE mode we never deploy or run any artifacts from the deployment. These should always be deployed as a .war otherwise the test code gets added as a Library in the .war constructed by Arquillian (did not realize this when writing these tests).

Below is before/after this change:
Screenshot 2024-04-17 at 10 15 54
Screenshot 2024-04-17 at 10 08 32

  • Also removed example tests that already have real equivalents
  • Fixed some typos

@KyleAure KyleAure added bug Something isn't working test Something test-related labels Apr 17, 2024
@KyleAure KyleAure self-assigned this Apr 17, 2024
@KyleAure KyleAure changed the title Use web archive instead of java archive Use web archive instead of java archive for standalone Apr 17, 2024
@KyleAure KyleAure requested a review from gavinking April 17, 2024 15:24
@gavinking
Copy link
Contributor

@starksm64 WDYT?

gavinking
gavinking approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scott says it looks good.

@KyleAure KyleAure merged commit c0d62a5 into jakartaee:main Apr 17, 2024
3 checks passed
@KyleAure KyleAure deleted the 705-standalone-jar-to-web branch April 17, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinking gavinking gavinking approved these changes

Assignees

@KyleAure KyleAure

Labels
bug Something isn't working test Something test-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TCK Challenge]: ee.jakarta.tck.data.standalone.persistence.PersistenceEntityTests in non-standalone mode
2 participants
@KyleAure @gavinking