Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further refactoring of CDI tests #711

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

KyleAure
Copy link
Contributor

Related #709

At this point we are testing CDI and the integration with Jakarta Data, but we don't actually need to implement the repositories for our goals.

I have simplified the CDI tests down for what we actually want to test from the Spec which is:

  1. Jakarta Data providers can co-exist based on the provider attribute of @Repository
  2. Jakarta Data providers can co-exist based on the @EntityDefining annotation from @Repository via the Entity.

I am still new to CDI and still learning so I think I was a bit heavy handed before.

@KyleAure KyleAure added bug Something isn't working test Something test-related labels Apr 18, 2024
@KyleAure KyleAure self-assigned this Apr 18, 2024
@KyleAure KyleAure requested a review from gavinking April 18, 2024 16:19
Copy link
Contributor

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KyleAure KyleAure merged commit f341181 into jakartaee:main Apr 18, 2024
3 checks passed
@KyleAure KyleAure deleted the refactor-tck-logic branch April 18, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Something test-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants