Tck test at the method testBeyondFinalPage #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Otavio Santana <[email protected]>
njr-11
reviewed
Jul 27, 2024
tck/src/main/java/ee/jakarta/tck/data/standalone/entity/EntityTests.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Otavio Santana <[email protected]>
…Tests.java Co-authored-by: Nathan Rauh <[email protected]>
njr-11
requested changes
Jul 29, 2024
There was a problem hiding this comment.
All of the changes in the additional commit have the same problem that I identified in the first review, that they are no longer requiring totals to work for relational databases. I have added suggestions to fix all of them. Also, I noticed that some of them were going beyond allowing the totalElement/totalPages to be unsupported and also adding other operations. I have the code suggestions restoring those assertions as well.
tck/src/main/java/ee/jakarta/tck/data/standalone/entity/EntityTests.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/data/standalone/entity/EntityTests.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/data/standalone/entity/EntityTests.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/data/standalone/entity/EntityTests.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/data/standalone/entity/EntityTests.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/data/standalone/entity/EntityTests.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/data/standalone/entity/EntityTests.java
Outdated
Show resolved
Hide resolved
7 tasks
…Tests.java Co-authored-by: Nathan Rauh <[email protected]>
…Tests.java Co-authored-by: Nathan Rauh <[email protected]>
…Tests.java Co-authored-by: Nathan Rauh <[email protected]>
…Tests.java Co-authored-by: Nathan Rauh <[email protected]>
…Tests.java Co-authored-by: Nathan Rauh <[email protected]>
…Tests.java Co-authored-by: Nathan Rauh <[email protected]>
…Tests.java Co-authored-by: Nathan Rauh <[email protected]>
njr-11
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.