-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix testUpdateQueryWithWhereClause method #838
Conversation
Signed-off-by: Otavio Santana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like one of the skips (covering key-value without eventual consistency) was lost, so I added a suggestion to put it back.
Also, I see this line later in the test which is another occurrence that will need to be covered:
assertEquals(2, shared.deleteIfPositive());
Also, I think we need to add a method to the MultipleEntityRepo returning void,
@Query("DELETE FROM Coordinate WHERE x > 0.0d AND y > 0.0f")
void deleteIfPositive_EventualConsistency();
which can be used within the catch where it says:
// Use alternative approach for ensuring no data is present:
because it doesn't currently do anything, and then subsequent assertions check that the data was deleted.
tck/src/main/java/ee/jakarta/tck/data/standalone/entity/EntityTests.java
Outdated
Show resolved
Hide resolved
…Tests.java Co-authored-by: Nathan Rauh <[email protected]>
Signed-off-by: Otavio Santana <[email protected]>
Signed-off-by: Otavio Santana <[email protected]>
Signed-off-by: Otavio Santana <[email protected]>
@njr-11 done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we also need to add the line to use the new method in the two places where it says "Use alternative approach..."
tck/src/main/java/ee/jakarta/tck/data/standalone/entity/EntityTests.java
Show resolved
Hide resolved
tck/src/main/java/ee/jakarta/tck/data/standalone/entity/EntityTests.java
Show resolved
Hide resolved
…Tests.java Co-authored-by: Nathan Rauh <[email protected]>
…Tests.java Co-authored-by: Nathan Rauh <[email protected]>
No description provided.