Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix testUpdateQueryWithWhereClause method #838

Merged
merged 8 commits into from
Sep 3, 2024

Conversation

otaviojava
Copy link
Contributor

No description provided.

@otaviojava
Copy link
Contributor Author

@njr-11 I forget to update this one:

#828

Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like one of the skips (covering key-value without eventual consistency) was lost, so I added a suggestion to put it back.

Also, I see this line later in the test which is another occurrence that will need to be covered:

        assertEquals(2, shared.deleteIfPositive());

Also, I think we need to add a method to the MultipleEntityRepo returning void,

    @Query("DELETE FROM Coordinate WHERE x > 0.0d AND y > 0.0f")
    void deleteIfPositive_EventualConsistency();

which can be used within the catch where it says:
// Use alternative approach for ensuring no data is present:

because it doesn't currently do anything, and then subsequent assertions check that the data was deleted.

@otaviojava
Copy link
Contributor Author

@njr-11 done

Copy link
Contributor

@njr-11 njr-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we also need to add the line to use the new method in the two places where it says "Use alternative approach..."

@otaviojava otaviojava merged commit 2e00920 into main Sep 3, 2024
5 checks passed
@otaviojava otaviojava deleted the update-delete-int-disable-2 branch September 3, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants