Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ee.jakarta.tck.persistence.core.criteriaapi.CriteriaUpdate.* tests don't seem to be initialing the Product table #1733

Closed
starksm64 opened this issue Jan 8, 2025 · 1 comment · Fixed by #1737
Closed

ee.jakarta.tck.persistence.core.criteriaapi.CriteriaUpdate.* tests don't seem to be initialing the Product table #1733

starksm64 opened this issue Jan 8, 2025 · 1 comment · Fixed by #1737

Comments

@starksm64
Copy link
Contributor

Describe the bug
All of the ee.jakarta.tck.persistence.core.criteriaapi.CriteriaUpdate.* tests are failing with unexpected counts from the Product entity table. This table is supposed to be getting loaded by the superclass UtilProductData#setupProductData that is annotated with the junit5 @BeforeEach, that is not getting called on the server side. This needs the legacy @SetupMethod used by the javatest framework.
starksm64 added a commit that referenced this issue Jan 9, 2025
@starksm64
Add the missing setup method that creates the product data contents
62b4e60 
Fixes #1733

Signed-off-by: Scott M Stark <[email protected]>
@starksm64
Copy link
Contributor Author

That was the wrong class to look at for the incontainer tests. The actual problem was a missing setup method that was calling the createProductData() method.

@starksm64 starksm64 mentioned this issue Jan 9, 2025
Merged
@starksm64 starksm64 mentioned this issue Jan 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the missing setup method that creates the product data contents jakartaee/platform-tck
1 participant
@starksm64