Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassLoader issue in embedded Arquillian #1178

Merged
merged 1 commit into from
May 26, 2023

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented May 26, 2023

Fixes Issue
helidon-io/helidon#6884

Related Issue(s)
helidon-io/helidon#6884

Describe the change
Using embedded Arquillian, there is only one JVM, so next line will not get the resource from the web application, it will get the test execution classpath (the file will not be found):
getClass().getResourceAsStream("/key.pub")
This suggested fix is more flexible, because the web container is able to set its own class loader.

Additional context
I faced this issue integrating this in Helidon.

CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow

Signed-off-by: Jorge Bescos Gascon <[email protected]>
@arjantijms
Copy link
Contributor

p.s. for Piranha Cloud and Arquillian I worked on an isolated class loader so tests won't pick up thing from the environment. Might be worthwhile to see if that can be applied to this situation as well at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants