Setting correct folder for beans.xml #1179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Bescos Gascon <[email protected]>
|
@starksm64 I think you created the tests. Does this change make sense to you?. |
|
Reading the spec, in the My understanding is that |
|
My bad, I found it can be in WEB-INF, int the Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
helidon-io/helidon#6799
Related Issue(s)
helidon-io/helidon#6799
Describe the change
There are a couple of tests here that creates the beans.xml in
WEB-INF. Correct me if I am wrong, but I think the correct folder isWEB-INF/classes/META-INF.Additional context
This makes some issues in Helidon Arquillian container because when it does not find a beans.xml it will create a default one. I can fix it in Helidon if this PR does not make sense.
CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @OndroMih @dmatej
@starksm64 @scottmarlow