-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Node.js version 20 #827
Conversation
…/react-dom to v18.2.18
…mmands to allow electron run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this PR. This update was long overdue.
I see the CI build failing. It looks like the NodeJS version in the workflow needs to be updated.
…ersion to v3.0.0" This reverts commit c81c940.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #827 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 139 139
Lines 4356 4386 +30
Branches 823 852 +29
=========================================
+ Hits 4356 4386 +30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the latest changes. LGTM 👌
Thanks for this long awaited fix.
Closes #(820)
Description
Added support for Node.js version 20