Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: 优化验证LDAP DN(Distinguished Name)字符串是否有效 #196

Merged
merged 1 commit into from
Dec 4, 2024
Merged

perf: 优化验证LDAP DN(Distinguished Name)字符串是否有效 #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions src/main/java/com/jmal/clouddisk/service/impl/AuthServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ private void init() {
}

private static LdapContextSource loadLdapConfig(LdapConfigDTO ldapConfigDTO) {
if (isNotValidBaseDn(ldapConfigDTO.getBaseDN())) {
if (isNotValidDn(ldapConfigDTO.getBaseDN())) {
throw new CommonException(ExceptionType.WARNING.getCode(), "BaseDN格式错误, 应为 dc=xxx,dc=xxx");
}
if (isNotValidDn(ldapConfigDTO.getUserDN())) {
Expand Down Expand Up @@ -136,18 +136,6 @@ private ResponseResult<Object> ldapLogin(HttpServletResponse response, ConsumerD
return ResultUtil.error(loginError());
}

/**
* 验证LDAP BaseDN字符串是否有效。
*
* @param baseDn 要验证的BaseDN字符串。
* @return 如果BaseDN有效，则为true；否则为false。
*/
public static boolean isNotValidBaseDn(String baseDn) {
// 正则表达式来校验BaseDN的格式
String regex = "((cn|dc|ou)=([^,]+))(,\\s*(cn|dc|ou)=([^,]+))*";
return baseDn == null || !baseDn.matches(regex);
}

/**
* 验证LDAP DN(Distinguished Name)字符串是否有效
*
Expand Down