Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS legibility improvements #3

Merged
merged 5 commits into from
Jun 19, 2012
Merged

iOS legibility improvements #3

merged 5 commits into from
Jun 19, 2012

Conversation

jwheare
Copy link
Contributor

@jwheare jwheare commented May 20, 2012

This mainly improves the search results, but I added some title and meta viewport tags to the nearby and stop pages too (with some css tweaks to support, the overall effect is mostly unchanged)

Screenshot from the iOS simulator http://jouire.com/screens/3k/fqg9ml91k4gcc.png

I haven't tested on android, and I don't know how happy you are about aping Apple's list style, but hey.

@james
Copy link
Owner

james commented May 20, 2012

I'm game for this, just need to see how it works on kindle. My one if broken, replacement coming on Wednesday, unless someone else has one.

@jwheare
Copy link
Contributor Author

jwheare commented May 20, 2012

I discovered while working on this that the only way to make a home screened web app remain within the app and not switch to safari when you click links is to do onclick window.location = link.href;

http://stackoverflow.com/questions/2898740/iphone-safari-web-app-opens-links-in-new-window

I didn't want to include that change in this pull request because it's a f*cking insane hack, but it does make the experience a lot nicer if you do save it to home screen (particularly nice if you save the /nearby link). What do you think?

@jwheare
Copy link
Contributor Author

jwheare commented May 20, 2012

AFAICT it wouldn't really have any adverse side effects for other browser. Those that support JS should behave fine, those that don't will fall back to the href.

@jwheare
Copy link
Contributor Author

jwheare commented May 20, 2012

Oh and this is a version that is all smug with graceful behaviour and feature detection etc https://gist.github.com/1042026

Looks blessed by the gods of HTML5, I'll add it to my fork and this pull request.

@jwheare
Copy link
Contributor Author

jwheare commented May 28, 2012

You got your kindle back yet?

@james
Copy link
Owner

james commented Jun 19, 2012

Yes, but now I've lost it. Gah.

@jwheare
Copy link
Contributor Author

jwheare commented Jun 19, 2012

Just push it. We'll do it live.

On 19 Jun 2012, at 11:01 AM, James Darling
[email protected]
wrote:

Yes, but now I've lost it. Gah.


Reply to this email directly or view it on GitHub:
#3 (comment)

james added a commit that referenced this pull request Jun 19, 2012
iOS legibility improvements
@james james merged commit fd697fe into james:master Jun 19, 2012
@james
Copy link
Owner

james commented Jun 19, 2012

FUCK IT. IT'S LIVE.

I think it works.

@james
Copy link
Owner

james commented Jun 19, 2012

The inclusion of a doctype is making me feel like a grown up.

@james
Copy link
Owner

james commented Jun 19, 2012

I'm scared.

@jwheare
Copy link
Contributor Author

jwheare commented Jun 19, 2012

@james
Copy link
Owner

james commented Jun 19, 2012

SHIT

@james
Copy link
Owner

james commented Jun 19, 2012

FIXED. Maybe.

@jwheare
Copy link
Contributor Author

jwheare commented Jun 19, 2012

CONFIRMED. Boom. We're in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants