Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing scenarios with CompletableFuture #564

Merged
merged 51 commits into from
Jan 28, 2025

Conversation

jabrena
Copy link
Contributor

@jabrena jabrena commented Jan 6, 2025

  • Solution implemented in Java with Completable futures (Except Scenario 4 & 10)
  • Added support for Devcontainers & Gitpod for Java scenarios

@jabrena jabrena changed the title Implementing scenarios with CompletableFuture Implementing scenarios with CompletableFuture WIP Jan 6, 2025
@jamesward
Copy link
Owner

Thanks for getting this started!

@jamesward
Copy link
Owner

I've rebased this and added the GitHub Action to test it.

@jabrena
Copy link
Contributor Author

jabrena commented Jan 21, 2025

Yes, I checked the logs. It is running on java 20. How to run in java 23 @jamesward?

@jabrena
Copy link
Contributor Author

jabrena commented Jan 21, 2025

I saw the pipeline, tomorrow I will update to java 23, many thanks

@jabrena
Copy link
Contributor Author

jabrena commented Jan 21, 2025

In the solution, can I use Either or something similar to improve the error handling?

@jamesward
Copy link
Owner

You can use whatever - no rules in EasyRacer - except to implement the scenarios, we can just clarify in docs if you need to pull in deps.

@jabrena
Copy link
Contributor Author

jabrena commented Jan 22, 2025

I have upgraded the pipeline for java-cf.

Where is the repository to generate the pipeline in order to update it?

Note: take a look the scenario 8 vs OOP approach in java-loom :)

Good night from Madrid

@jabrena
Copy link
Contributor Author

jabrena commented Jan 23, 2025

Nice parameters:

  ["java-cf"] = new {
    steps = GitHubAction.Java.mavenTestSteps("--batch-mode --no-transfer-progress verify", "java-cf", "graalvm", "23")
  }

@jabrena
Copy link
Contributor Author

jabrena commented Jan 26, 2025

@jamesward, how to enable the logs to see the internal behaviour in Scenario Server?

@jabrena
Copy link
Contributor Author

jabrena commented Jan 27, 2025

@jamesward, I have reviewed the solution for all scenarios except 4 & 10 that they are pending. Can you review the solution and merge to main?

@jabrena jabrena changed the title Implementing scenarios with CompletableFuture WIP Implementing scenarios with CompletableFuture Jan 27, 2025
@jabrena
Copy link
Contributor Author

jabrena commented Jan 28, 2025

I have disabled few logs to improve the code readability.

Can we merge the PR with Squash & merge?

Cheers

Juan Antonio

@jamesward jamesward merged commit 1f1ff55 into jamesward:main Jan 28, 2025
1 check passed
@jamesward
Copy link
Owner

Thank you @jabrena for all the work on this!

@jabrena jabrena deleted the feature/java-cf branch January 28, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants