Remove GitHub version call

jamiefdhurst · Jul 30, 2023 · 1bded30 · 1bded30
1 parent f627041
commit 1bded30
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 40 deletions.
diff --git a/blog/__init__.py b/blog/__init__.py
@@ -15,13 +15,6 @@ def create_app(test_config=None):
     except OSError:
         pass
 
-    github = requests.get('https://api.github.com/repos/jamiefdhurst/blog/releases',
-        auth=(app.config['GITHUB_USERNAME'], app.config['GITHUB_TOKEN']))
-    if github.status_code == 200:
-        response = github.json()
-        if len(response):
-            app.config.update(VERSION=response[0]['name'])
-
     @app.before_request
     def load_version():
         # pylint: disable=assigning-non-slot

diff --git a/blog/config.py b/blog/config.py
@@ -2,6 +2,4 @@
 
 SECRET_KEY = environ.get('SECRET_KEY', default='dev')
 ARTICLES_DIR = environ.get('ARTICLES_DIR', default='articles/')
-GITHUB_USERNAME = environ.get('GITHUB_USERNAME', default='')
-GITHUB_TOKEN = environ.get('GITHUB_TOKEN', default='')
-VERSION = 'DEVELOPMENT'
+VERSION = 'v0.18'
diff --git a/tests/conftest.py b/tests/conftest.py
@@ -3,28 +3,10 @@
 from blog import create_app
 
 
-@pytest.fixture
-def mock_github_request_empty_response(requests_mock):
-    requests_mock.get(
-        'https://api.github.com/repos/jamiefdhurst/blog/releases',
-        json='',
-    )
-
-
-@pytest.fixture
-def mock_github_request(requests_mock):
-    requests_mock.get(
-        'https://api.github.com/repos/jamiefdhurst/blog/releases',
-        json=[{'name': 'v1.0-TEST'}],
-    )
-
-
 @pytest.fixture
 def app():
     app = create_app({
         'ARTICLES_DIR': 'tests/articles/',
-        'GITHUB_USERNAME': 'jamiefdhurst',
-        'GITHUB_TOKEN': 'example',
         'TESTING': True,
         'VERSION': 'DEVELOPMENT',
     })

diff --git a/tests/test_factory.py b/tests/test_factory.py
@@ -4,21 +4,9 @@ def test_config():
     assert not create_app().testing
     app = create_app({
         'ARTICLES_DIR': 'tests/articles/',
-        'GITHUB_USERNAME': 'jamiefdhurst',
-        'GITHUB_TOKEN': 'example',
         'TESTING': True})
     assert app.testing
     assert app.config['ARTICLES_DIR'] == 'tests/articles/'
-    assert app.config['GITHUB_USERNAME'] == 'jamiefdhurst'
-    assert app.config['GITHUB_TOKEN'] == 'example'
-
-def test_github_empty_response(mock_github_request_empty_response, client):
-    response = client.get('/')
-    assert b'System DEVELOPMENT' in response.data
-
-def test_github_successful_response(mock_github_request, client):
-    response = client.get('/')
-    assert b'System v1.0-TEST' in response.data
 
 def test_404(client):
     response = client.get('/not-found-path')