Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write down syntax highlighting design principles #58

Closed
wants to merge 0 commits into from

Conversation

jan-warchol
Copy link
Owner

Hi @dngray, I wrote down some of my thoughts on choosing colors for particular token types. Let me know if you have any comments.

@dngray
Copy link
Contributor

dngray commented Aug 25, 2019

Reading over those points I agree 100%.

warm colors (orange, yellow) are best for tokens associated with action

I did this with the i3wm theme and windows requesting urgency.

comments must be gray, so that they fade into background (unlike many schemes in which comments are green and clutter the view)

It might be worth having a look at this article from a while back, it has quite a different opinion on that Your syntax highlighter is wrong and the thread from HN and repost. I am curious to know what your thoughts on (1: ‘Comments are cruft’) were.

I don't personally agree about the diff remarks neither did this person. I consider red meaning it was shit so it was removed. Green is good, and it is the new stuff that is better. Any more meaning than that is really not inferred.

should boilerplate be blue? or gray? or not colored at all?

At the moment I think it is gray, if say you consider DOCTYPE in HTML to be boiler plate. It's not something that needs a huge amount of attention so I think that's okay. Solarized does the same thing.

Other than that I would agree with the other points. I don't change my color scheme very often at all, and up until now I have been using Solarized. Previously I used Xoria256.

@jan-warchol
Copy link
Owner Author

I've just realized that this commit was rebased and merged some time ago (but I forgot to update branch/close PR)...

@jan-warchol jan-warchol closed this Mar 7, 2020
@jan-warchol jan-warchol deleted the design-principles branch March 7, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants