Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim: improve coloring of keyword completion (fix #33) #62

Closed
wants to merge 2 commits into from

Conversation

jan-warchol
Copy link
Owner

image

How do you like this, @dngray @Envielox ?

@dngray
Copy link
Contributor

dngray commented Oct 31, 2019

1572493048

Looks good to me. I assume the last line being highlighted "return a replacement string to be used." is supposed to be like that?

@jan-warchol
Copy link
Owner Author

I assume the last line being highlighted "return a replacement string to be used." is supposed to be like that?

Actually I'm not sure what is responsible for this particular element as it doesn't appear in my vim. I've pushed another commit, can you check whether it changed?

jan-warchol added a commit that referenced this pull request Oct 31, 2019
There is one more completion interface element that I want to color, but
I'm not sure what's its name. See comment in #62.
@dngray
Copy link
Contributor

dngray commented Oct 31, 2019

Actually I'm not sure what is responsible for this particular element as it doesn't appear in my vim. I've pushed another commit, can you check whether it changed?

It didn't appear to change anything. It also seems now this doesn't work at all with nvimqt (even in broken form), these two commits I don't think are responsible. Hopefully that will get fixed when we solve #47 and use colortheme.

1572513059

Btw I am using neoclide/coc.nvim there, a fairly standard auto-completion plugin on some python code.

@dngray
Copy link
Contributor

dngray commented Oct 31, 2019

I tested this with lifepillar/vim-solarized8 (nvim-qt) and the bottom line doesn't appear to be highlighted.

1572515541

There is one more completion interface element that I want to color, but
I'm not sure what's its name. See comment in #62.
@dngray
Copy link
Contributor

dngray commented Nov 27, 2019

Awesome this seems to be fixed:

1574820005

@jan-warchol jan-warchol deleted the vim-completion branch March 6, 2020 20:09
clach04 pushed a commit to clach04/selenized that referenced this pull request Dec 14, 2024
Use vim-colortemplate to generate vim theme files in all 4 variants
(dark, light, black, white). Styling is almost the same as in previous
version of the theme.

It also fixes jan-warchol#33 and closes jan-warchol#62 (makes it obsolete).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants