Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap doom emacs theme #85

Closed
wants to merge 1 commit into from
Closed

Bootstrap doom emacs theme #85

wants to merge 1 commit into from

Conversation

bersace
Copy link

@bersace bersace commented May 25, 2020

Hi,

I started a Selenized Dark theme for Doom Emacs. Here is my contribution.

I didn't submit this theme to hlissner/emacs-doom-themes to share design and iterate with selenized community.

Screenshot attached to PR.

What do you think of this ?

screenshot

@jan-warchol
Copy link
Owner

Nice! Thanks for providing the screenshot, it is helpful. Generally looks sensible.

  1. Can you make comments italic?
  2. There's a discussion whether keywords should be green or yellow. Could you please make them yellow, and use green for the things that are yellow now?
  3. Could you make a screenshot using code samples from this repo? I'm very familar with them and it'll help me in making a detailed review. Python, ruby, javascript and bash (from root dir) will be fine, no need for more.

@bersace
Copy link
Author

bersace commented May 28, 2020

@jan-warchol thanks for the review. I applied your suggestions and fixed magenta color. Screenshot is updated and added to PR description.

@simendsjo
Copy link

I tried this theme now, and notice some colors have a bad contrast.

Selenized:
image

Solarized:
image

@simendsjo
Copy link

Looks like the same gray is used other places, like in the magit header:
image
PS: Only using git as a backup here -- I use commit messages in production :)

@bersace
Copy link
Author

bersace commented May 18, 2021

Hi @simendsjo thanks for the feedback. This theme is just a starting point. Contribution welcome :-)

@bersace bersace closed this by deleting the head repository Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants