Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make review feedback changes #2

Merged
merged 1 commit into from
Nov 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Omnidian Reader
# Obsidian Note Annotations

Better active reading experience in Obsidian.

Expand Down
6 changes: 3 additions & 3 deletions manifest.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"id": "omnidian",
"name": "Omnidian",
"id": "note-annotations",
"name": "Note Annotations",
"version": "1.0.0",
"minAppVersion": "1.7.0",
"description": "Better active reading experience in Obsidian",
"description": "Add multi-colored highlights and comments to your notes",
"author": "Jan Beck",
"authorUrl": "https://github.com/jancbeck",
"isDesktopOnly": false
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "obsidian-omnidian-plugin",
"name": "obsidian-note-annotations",
"version": "1.0.0",
"description": "This is a sample plugin for Obsidian (https://obsidian.md)",
"main": "./build/main.js",
Expand Down
4 changes: 1 addition & 3 deletions sandbox/.obsidian/community-plugins.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
[
"hot-reload",
"omnidian",
"obsidian42-brat",
"datacore"
"note-annotations"
]
2 changes: 1 addition & 1 deletion sandbox/.obsidian/workspace-mobile.json
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
"daily-notes:Open today's daily note": false,
"templates:Insert template": false,
"command-palette:Open command palette": false,
"omnidian:Enable Highlighting Mode": false
"note-annotations:Enable highlighting mode": false
}
},
"active": "bc3d91a8ac10e245",
Expand Down
339 changes: 171 additions & 168 deletions sandbox/.obsidian/workspace.json
Original file line number Diff line number Diff line change
@@ -1,169 +1,172 @@
{
"main": {
"id": "101c966f106bfdb6",
"type": "split",
"children": [
{
"id": "d5cbfcc6eef3af32",
"type": "tabs",
"children": [
{
"id": "c5d01206e1e21e8a",
"type": "leaf",
"state": {
"type": "markdown",
"state": {
"file": "Highlights.md",
"mode": "source",
"source": false
},
"icon": "lucide-file",
"title": "Highlights"
}
}
]
}
],
"direction": "vertical"
},
"left": {
"id": "316d34fd47bc54cb",
"type": "split",
"children": [
{
"id": "546cfc52a59bc6c4",
"type": "tabs",
"children": [
{
"id": "116a2ce92d2b226a",
"type": "leaf",
"state": {
"type": "file-explorer",
"state": {
"sortOrder": "alphabetical"
},
"icon": "lucide-folder-closed",
"title": "Files"
}
},
{
"id": "b04ab1107b1b70ff",
"type": "leaf",
"state": {
"type": "search",
"state": {
"query": "",
"matchingCase": false,
"explainSearch": false,
"collapseAll": false,
"extraContext": false,
"sortOrder": "alphabetical"
},
"icon": "lucide-search",
"title": "Search"
}
},
{
"id": "5e4c71787eee6adc",
"type": "leaf",
"state": {
"type": "bookmarks",
"state": {},
"icon": "lucide-bookmark",
"title": "Bookmarks"
}
}
]
}
],
"direction": "horizontal",
"width": 300
},
"right": {
"id": "476b63e4be6d7dbb",
"type": "split",
"children": [
{
"id": "e829c590a656bf93",
"type": "tabs",
"children": [
{
"id": "93db31e202b686bb",
"type": "leaf",
"state": {
"type": "backlink",
"state": {
"file": "README.md",
"collapseAll": false,
"extraContext": false,
"sortOrder": "alphabetical",
"showSearch": false,
"searchQuery": "",
"backlinkCollapsed": false,
"unlinkedCollapsed": true
},
"icon": "links-coming-in",
"title": "Backlinks for Welcome"
}
},
{
"id": "75503949c973e42a",
"type": "leaf",
"state": {
"type": "outgoing-link",
"state": {
"file": "README.md",
"linksCollapsed": false,
"unlinkedCollapsed": true
},
"icon": "links-going-out",
"title": "Outgoing links from Welcome"
}
},
{
"id": "10b6340a2d11e14d",
"type": "leaf",
"state": {
"type": "tag",
"state": {
"sortOrder": "frequency",
"useHierarchy": true
},
"icon": "lucide-tags",
"title": "Tags"
}
},
{
"id": "382c9833c07e8ed4",
"type": "leaf",
"state": {
"type": "outline",
"state": {
"file": "README.md"
},
"icon": "lucide-list",
"title": "Outline of Welcome"
}
}
]
}
],
"direction": "horizontal",
"width": 300,
"collapsed": true
},
"left-ribbon": {
"hiddenItems": {
"switcher:Open quick switcher": false,
"graph:Open graph view": false,
"canvas:Create new canvas": false,
"daily-notes:Open today's daily note": false,
"templates:Insert template": false,
"command-palette:Open command palette": false,
"omnidian:Enable Highlighting Mode": false,
"obsidian42-brat:BRAT": false
}
},
"active": "c5d01206e1e21e8a",
"lastOpenFiles": ["README.md"]
}
"main": {
"id": "101c966f106bfdb6",
"type": "split",
"children": [
{
"id": "d5cbfcc6eef3af32",
"type": "tabs",
"children": [
{
"id": "c5d01206e1e21e8a",
"type": "leaf",
"state": {
"type": "markdown",
"state": {
"file": "Start here.md",
"mode": "source",
"source": false
},
"icon": "lucide-file",
"title": "Start here"
}
}
]
}
],
"direction": "vertical"
},
"left": {
"id": "316d34fd47bc54cb",
"type": "split",
"children": [
{
"id": "546cfc52a59bc6c4",
"type": "tabs",
"children": [
{
"id": "116a2ce92d2b226a",
"type": "leaf",
"state": {
"type": "file-explorer",
"state": {
"sortOrder": "alphabetical"
},
"icon": "lucide-folder-closed",
"title": "Files"
}
},
{
"id": "b04ab1107b1b70ff",
"type": "leaf",
"state": {
"type": "search",
"state": {
"query": "",
"matchingCase": false,
"explainSearch": false,
"collapseAll": false,
"extraContext": false,
"sortOrder": "alphabetical"
},
"icon": "lucide-search",
"title": "Search"
}
},
{
"id": "5e4c71787eee6adc",
"type": "leaf",
"state": {
"type": "bookmarks",
"state": {},
"icon": "lucide-bookmark",
"title": "Bookmarks"
}
}
]
}
],
"direction": "horizontal",
"width": 300
},
"right": {
"id": "476b63e4be6d7dbb",
"type": "split",
"children": [
{
"id": "e829c590a656bf93",
"type": "tabs",
"children": [
{
"id": "93db31e202b686bb",
"type": "leaf",
"state": {
"type": "backlink",
"state": {
"file": "README.md",
"collapseAll": false,
"extraContext": false,
"sortOrder": "alphabetical",
"showSearch": false,
"searchQuery": "",
"backlinkCollapsed": false,
"unlinkedCollapsed": true
},
"icon": "links-coming-in",
"title": "Backlinks for Welcome"
}
},
{
"id": "75503949c973e42a",
"type": "leaf",
"state": {
"type": "outgoing-link",
"state": {
"file": "README.md",
"linksCollapsed": false,
"unlinkedCollapsed": true
},
"icon": "links-going-out",
"title": "Outgoing links from Welcome"
}
},
{
"id": "10b6340a2d11e14d",
"type": "leaf",
"state": {
"type": "tag",
"state": {
"sortOrder": "frequency",
"useHierarchy": true
},
"icon": "lucide-tags",
"title": "Tags"
}
},
{
"id": "382c9833c07e8ed4",
"type": "leaf",
"state": {
"type": "outline",
"state": {
"file": "README.md"
},
"icon": "lucide-list",
"title": "Outline of Welcome"
}
}
]
}
],
"direction": "horizontal",
"width": 300,
"collapsed": true
},
"left-ribbon": {
"hiddenItems": {
"switcher:Open quick switcher": false,
"graph:Open graph view": false,
"canvas:Create new canvas": false,
"daily-notes:Open today's daily note": false,
"templates:Insert template": false,
"command-palette:Open command palette": false,
"obsidian42-brat:BRAT": false,
"note-annotations:Enable highlighting mode": false
}
},
"active": "c5d01206e1e21e8a",
"lastOpenFiles": [
"Plugins make Obsidian special for you.md",
"README.md"
]
}
Loading