fix outdir for windows (for good this time...) #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
closing and reopening to trigger the CI. |
|
but before merging, let's please wait for nim-lang/Nim#13382 to be green :) |
|
sure |
|
nim-lang/Nim#13382 is green at last! thanks for your patience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry for the noise @jangko, looks like the previous attempts didn't work; I've now bitten the bullet and found a windows VM to test this on and make sure it all works; and for extra check I've added this to nim-lang/Nim#13382 to make sure PR is green with this change:
so let's wait for nim CI nim-lang/Nim#13382 to be green before merging this, then I'll undo the above line from the nim PR.
note
--outdir:'$projectdir'unfortunately doesn't seem to work on windows (this shouldn't be hard to fix in Nim); so I'm using--outdir:testshere