Skip to content

Commit

Permalink
Bug 1485856 [wpt PR 12662] - HTML: review followup, a=testonly
Browse files Browse the repository at this point in the history
Automatic update from web-platform-testsHTML: review followup (#12662)

Follow up to review comments in
web-platform-tests/wpt#12636.
--

wpt-commits: a63935ce4574b32d850cf0063f6ea508ad517986
wpt-pr: 12662
  • Loading branch information
TimothyGu authored and moz-wptsync-bot committed Aug 31, 2018
1 parent 5e04d79 commit 6a76c55
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
2 changes: 1 addition & 1 deletion testing/web-platform/meta/MANIFEST.json
Original file line number Diff line number Diff line change
Expand Up @@ -607230,7 +607230,7 @@
"testharness"
],
"html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window.js": [
"282e58e9c380fc214365522163c8bc09a67afc3b",
"4e7c649f4533958112e6bd1dd59537619d7cc62d",
"testharness"
],
"html/webappapis/microtask-queuing/queue-microtask-exceptions.any.js": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ test(t => {
t.add_cleanup(() => frame.remove());
assert_equals(frame.contentDocument.URL, "about:blank");
assert_equals(frame.contentWindow.location.href, "about:blank");
frame.contentDocument.open();
assert_equals(frame.contentDocument.open(), frame.contentDocument);
assert_equals(frame.contentDocument.URL, document.URL);
assert_equals(frame.contentWindow.location.href, document.URL);
}, "document.open() changes document's URL (fully active document)");
Expand All @@ -26,7 +26,7 @@ async_test(t => {

frame.onload = t.step_func_done(() => {
// Now childDoc is still active but no longer fully active.
childDoc.open();
assert_equals(childDoc.open(), childDoc);
assert_equals(childDoc.URL, blankURL);
assert_equals(childWin.location.href, blankURL);
});
Expand All @@ -40,6 +40,9 @@ test(t => {
t.add_cleanup(() => frame.remove());
const doc = frame.contentDocument;

// We do not test for win.location.href in this test due to
// https://github.com/whatwg/html/issues/3959.

// Right now the frame is connected and it has an active document.
assert_equals(doc.URL, "about:blank");

Expand All @@ -55,6 +58,9 @@ async_test(t => {
const frame = document.createElement("iframe");
t.add_cleanup(() => frame.remove());

// We do not test for win.location.href in this test due to
// https://github.com/whatwg/html/issues/3959.

frame.onload = t.step_func(() => {
const doc = frame.contentDocument;
// Right now the frame is connected and it has an active document.
Expand Down

0 comments on commit 6a76c55

Please sign in to comment.