Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many small patches in a trenchcoat #54

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

0xf0xx0
Copy link

@0xf0xx0 0xf0xx0 commented Jul 8, 2023

these changes are individually pretty small, so i lumped em into one pr. it can be split with little issue uwu

should also be tested on mainnet, ive been usin a local regtest

new

  • implemented a privacy mode that disables fiat entirely, like btc-rpc-explorer

general maintenance

  • updated the dependencies to latest releases
  • updated rpc.proto to v0.18.0-beta

replaced

  • cdn scripts have been replaced with local modules
  • base64url with Buffer.from(string, 'base64url')

ui fixes

  • disabled autocomplete on the password input and message signature forms
  • the option modal is now big enough for its contents
  • fixed the local currency unit when hovering over a btc value
  • added decimals to satoshis (3 places)
  • unknown nodes have their links removed, the node page is just a error
    unk node

ui/ux updating

general

  • the ui now takes the entire screen width
  • the currency options are no longer hard-coded
    • added msat, bits, and mBTC to the display currency list
  • merged the *-channel-row views into one common view
    • added the copy button to all channel ids instead of just closed, and txids

/

  • the active node icon is now the home icon
    active home

/login

  • failed logins properly retry instead of passing the check and then corrupting
  • related: passwordUtils is no longer async; node:crypto added .scryptSync

/forwarding-history

  • if fee earned is less than 1 sat, the fee is displayed in msat
  • total channel fees are displayed on the outgoing channels now
  • the channel tabs outgoing channel tab now follows the selected sort
  • fees are tallied by fee_msat
  • effective ppm was added to the summary and entries
    summary
    entries

/local-channels

  • changed the color of inactive channels from -alert to bs-gray-500
  • removed the "TX" pill from pending channels
  • changed the color of the public channel pill from -alert to -info to match the blue/green pair of outbound/inbound
  • forced the public/private and outbound/inbound pills to stack; this keeps channel rows from spilling
  • non-active channels now display the correct public/private and outbound/inbound status
  • added a "Closed" pill to replace the public/private pills when a channel is closed
    channel statuses

/openchannel

  • increased the width of the input boxes
    wide boxes

/node

  • merged the node color swatch and the hex code text (its cute :3)
    merged

/invoices

  • added the RB abbreviation for invoice route-blinding

/wallet

  • added taproot address generation
    taproot addr gen

full preview

@0xf0xx0 0xf0xx0 marked this pull request as draft October 11, 2023 22:13
@0xf0xx0
Copy link
Author

0xf0xx0 commented Oct 11, 2023

Needs some more work...

@0xf0xx0 0xf0xx0 marked this pull request as ready for review October 12, 2023 20:14
@0xf0xx0 0xf0xx0 force-pushed the quick-patches branch 3 times, most recently from f97b37f to 2411716 Compare October 14, 2023 01:37
@0xf0xx0 0xf0xx0 force-pushed the quick-patches branch 8 times, most recently from 64365c3 to 17a4604 Compare November 4, 2023 22:22
@0xf0xx0
Copy link
Author

0xf0xx0 commented Nov 15, 2023

I feel this is ready, although knowing my luck ill discover a issue right after lol

@0xf0xx0 0xf0xx0 force-pushed the quick-patches branch 4 times, most recently from 63b246d to b8f12fa Compare June 13, 2024 17:08
@0xf0xx0 0xf0xx0 changed the title some small patches many small patchesin a trenchcoat Jun 14, 2024
@0xf0xx0 0xf0xx0 changed the title many small patchesin a trenchcoat many small patches in a trenchcoat Jun 14, 2024
Copy link

@USER-id811214293 USER-id811214293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on ah approval merging lanes with eeasse be compatible on it. Synchorning 13 months. Comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants