-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
many small patches in a trenchcoat #54
Open
0xf0xx0
wants to merge
45
commits into
janoside:master
Choose a base branch
from
0xf0xx0:quick-patches
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs some more work... |
0xf0xx0
force-pushed
the
quick-patches
branch
from
October 12, 2023 19:00
daf7a33
to
6f1ae74
Compare
0xf0xx0
force-pushed
the
quick-patches
branch
3 times, most recently
from
October 14, 2023 01:37
f97b37f
to
2411716
Compare
0xf0xx0
force-pushed
the
quick-patches
branch
from
October 21, 2023 03:17
2411716
to
b48c6b7
Compare
0xf0xx0
force-pushed
the
quick-patches
branch
8 times, most recently
from
November 4, 2023 22:22
64365c3
to
17a4604
Compare
0xf0xx0
force-pushed
the
quick-patches
branch
from
November 6, 2023 18:57
17a4604
to
7b95cef
Compare
I feel this is ready, although knowing my luck ill discover a issue right after lol |
0xf0xx0
force-pushed
the
quick-patches
branch
4 times, most recently
from
June 13, 2024 17:08
63b246d
to
b8f12fa
Compare
0xf0xx0
changed the title
many small patchesin a trenchcoat
many small patches in a trenchcoat
Jun 14, 2024
USER-id811214293
suggested changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on ah approval merging lanes with eeasse be compatible on it. Synchorning 13 months. Comment.
…nd private or public, when the channel is opening/closing
… what was actually transferred
0xf0xx0
force-pushed
the
quick-patches
branch
from
September 30, 2024 16:11
145e093
to
24deaeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes are individually pretty small, so i lumped em into one pr. it can be split with little issue uwu
should also be tested on mainnet, ive been usin a local regtest
new
general maintenance
rpc.proto
to v0.18.0-betareplaced
base64url
withBuffer.from(string, 'base64url')
ui fixes
ui/ux updating
general
*-channel-row
views into one common view/
/login
passwordUtils
is no longer async;node:crypto
added.scryptSync
/forwarding-history
fee_msat
/local-channels
-alert
tobs-gray-500
-alert
to-info
to match the blue/green pair of outbound/inbound/openchannel
/node
/invoices
RB
abbreviation for invoiceroute-blinding
/wallet