Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useGzip option #620

Closed
wants to merge 3 commits into from
Closed

Add useGzip option #620

wants to merge 3 commits into from

Conversation

wood1986
Copy link

@wood1986 wood1986 commented Mar 20, 2017

I am unable to wire up the gzipped js or css with the existing configuration. Meanwhile, someone has created #61. Therefore, I choose to modify your code. If you agree my enhancement, I will add the test later.

@deanslamajr
Copy link

👍

@wood1986
Copy link
Author

I did add the tests. I believe the failed test is not come from mine

@mastilver
Copy link
Collaborator

@wood1986 see my comment here: #61 (comment)

Looks like this is being resolved by: webpack-contrib/compression-webpack-plugin#45

Can you confirm?

@wood1986
Copy link
Author

Any updates? I have been waiting compression-webpack-plugin for 2 months. As they need lot of people to sign off the big changes, why don't take mine at this moment. You can easily deprecate after their fix

@mastilver
Copy link
Collaborator

mastilver commented May 22, 2017

I don't think this is going in

Have you actually tried using this code to solve your issue: webpack-contrib/compression-webpack-plugin#45 ?

npm i --save-dev ijpiantanida/compression-webpack-plugin:emit-event

@wood1986 wood1986 closed this May 23, 2017
@wood1986 wood1986 reopened this May 23, 2017
@wood1986
Copy link
Author

wood1986 commented May 23, 2017

Sorry for the confusion. I confirm that iijpiantanida/compression-webpack-plugin:emit-event does not work. The final html is not using .gz

@farhan687
Copy link

I am looking for this feature. Any updates here?

@farhan687
Copy link

@mastilver that solution is not working, But this PR resolves gzip issue, Any plan to merge this PR?

@wood1986
Copy link
Author

wood1986 commented Jun 16, 2017

Finally, I choose not to use any compression plugin because they need a longer time fix it. Even if they fix it, I will not use. Here is my alternative. I am using ngnix and it has a plugin to handle the preprocessed gz. After the webpack bundling, gzip them with bash command. I think this is more reliable.

@mastilver
Copy link
Collaborator

@farhan687 I still don't believe this is an issue with html-webpack-plugin and I think the fix should come from compression-webpack-plugin

If you can provide me with a simple repository reproducing that error, I will be more that happy to have a look at it! :)

@wood1986 wood1986 closed this Dec 13, 2017
@lock
Copy link

lock bot commented May 31, 2018

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants