-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useGzip option #620
Add useGzip option #620
Conversation
👍 |
I did add the tests. I believe the failed test is not come from mine |
@wood1986 see my comment here: #61 (comment)
Can you confirm? |
Any updates? I have been waiting compression-webpack-plugin for 2 months. As they need lot of people to sign off the big changes, why don't take mine at this moment. You can easily deprecate after their fix |
I don't think this is going in Have you actually tried using this code to solve your issue: webpack-contrib/compression-webpack-plugin#45 ?
|
Sorry for the confusion. I confirm that |
I am looking for this feature. Any updates here? |
@mastilver that solution is not working, But this PR resolves gzip issue, Any plan to merge this PR? |
Finally, I choose not to use any compression plugin because they need a longer time fix it. Even if they fix it, I will not use. Here is my alternative. I am using ngnix and it has a plugin to handle the preprocessed gz. After the webpack bundling, gzip them with bash command. I think this is more reliable. |
@farhan687 I still don't believe this is an issue with If you can provide me with a simple repository reproducing that error, I will be more that happy to have a look at it! :) |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I am unable to wire up the gzipped js or css with the existing configuration. Meanwhile, someone has created #61. Therefore, I choose to modify your code. If you agree my enhancement, I will add the test later.