Fix FilesSpec parameters variance issues by making it a Mapping instead of a dict #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
FileSpec-variance
branch
from
6aef017 to
5aa7cb5
Compare
2 tasks
Avasam
force-pushed
the
FileSpec-variance
branch
from
d8e2933 to
eb71932
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes over around 30
reportArgumentTypetype errors right now in setuptools as found by pyright in pypa/setuptools#4192Around 80 as more dicts are typed more precisely than
dict[str, Any/Unknown]These would all eventually become type issues in mypy as well once that code is checked for.
Relates to #2