is_file should return false unless that file exists #55
Comments
jaraco
pushed a commit
that referenced
this issue
Jul 12, 2022
This patch adds a job that is able to accurately signal whether all the expectations of the required jobs to succeed are met. This job can then be used as a source of truth for judging whether "CI passes" and can be used in the branch protection. It also plays a role of a convenient "gate" — this is the only job that would have to be listed in the branch protection as opposed to listing every single job name generated by the test matrix (and they all have different names — it's not possible to just select one `test` job name). Ref: https://github.com/re-actors/alls-green#why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In
importlib.resources, I've had to add special handling for zipp.Path.is_file returning true when the name looks valid but the file doesn't exist. By contrast,pathlib.Path.is_filereturns False for paths that don't exist, even if they represent potentially vaild file references.The text was updated successfully, but these errors were encountered: