Force audience to incoming host when checkAudience is false
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `checkAudience` option is false, we need to force our audience to the incoming host, otherwise passport will fail all requests with a missmatched audience.
|
Also, apologies for the whitespace removal adding noise to the diff; didn't notice that till submitting the pull request; my editor does that automatically, and I didn't think about it. |
|
Closing in favor of #6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
checkAudienceoption is false, we need to force our audience to the incoming host, otherwise persona will fail all requests with a miss-matched audience.Alternatively, this could be the default if
checkAudiencewas false, andaudiencewas undefined, but it made sense to me to depend oncheckAudiencealone.This allows, for example, development on localhost, while testing with another computer browsing to the site via ip address. (I frequently test with my iPad this way).