Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UMD format from default build outputs #126

Merged
merged 3 commits into from
May 31, 2019
Merged

Remove UMD format from default build outputs #126

merged 3 commits into from
May 31, 2019

Conversation

nstfkc
Copy link
Contributor

@nstfkc nstfkc commented May 30, 2019 •
edited
Loading

With this pr tsdx build command no longer build umd format as default. But still tsdx build --format umd can be used for umd builds. #120

I have deleted umd output related tests. Should we add test cases for different format combinations?

@jaredpalmer jaredpalmer changed the title Fix: Remove UMD format from default build outputs Remove UMD format from default build outputs May 31, 2019
@jaredpalmer jaredpalmer merged commit e81f5a6 into jaredpalmer:master May 31, 2019
@agilgur5 agilgur5 mentioned this pull request Oct 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpalmer jaredpalmer jaredpalmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstfkc @jaredpalmer