Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cacheable - fix: if layer 2 has item then use expires or set to undef… #973

Conversation

jaredwray
Copy link
Owner

@jaredwray jaredwray commented Jan 8, 2025

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
cacheable - fix: if layer 2 has item then use expires or set to undefined

…ined

cacheable - fix: if layer 2 has item then use expires or set to undefined
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e2e0352) to head (4e6683d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #973   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           67        67           
=========================================
  Hits            67        67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredwray jaredwray merged commit a9d6078 into main Jan 8, 2025
7 checks passed
@jaredwray jaredwray deleted the cacheable---fix-if-layer-2-has-item-then-use-expires-or-set-to-undefined- branch January 8, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant