Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typescript compatibility for redis adapter #810

Merged
merged 5 commits into from
May 27, 2023

Conversation

chrisllontop
Copy link
Contributor

@chrisllontop chrisllontop commented May 19, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8b195b1) 100.00% compared to head (6c4e387) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #810   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2462      2463    +1     
  Branches       227       245   +18     
=========================================
+ Hits          2462      2463    +1     
Impacted Files Coverage Δ
packages/redis/src/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jaredwray
Copy link
Owner

@christianllv - can you get the testing back up to 100%?

@chrisllontop
Copy link
Contributor Author

Yes, I’m working on that now.

@chrisllontop
Copy link
Contributor Author

@jaredwray done.

@jaredwray jaredwray merged commit 2919dff into jaredwray:main May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants