Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing connection string with special characters #826

Merged

Conversation

jaredwray
Copy link
Owner

@jaredwray jaredwray commented May 23, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
parsing connection string with special characters

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7124c3b) 100.00% compared to head (cf199b3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #826   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         2453      2455    +2     
  Branches       227       227           
=========================================
+ Hits          2453      2455    +2     
Impacted Files Coverage Δ
packages/mysql/src/pool.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jaredwray jaredwray merged commit d8208e7 into main May 23, 2023
@jaredwray jaredwray deleted the mysql---validing-connection-string-with-special-charachers branch May 23, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant