-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add useRedisSets option #855
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 2541 2573 +32
Branches 328 335 +7
=========================================
+ Hits 2541 2573 +32
☔ View full report in Codecov by Sentry. |
@christianllv - can you add into the README the new option and what does it do? |
Also, will we be able to support setting this option on the main Keyv such as this: const keyv = new Keyv('redis://user:pass@localhost:6379', {useRedisSets: false}); I would also assume that by default we are using the Redis Sets to make sure this is backwards compatible? |
Hello @jaredwray we are using only sets (without sadd) only when useredisSets is true. But, by default is false. Should I set useRedisSets in true by default? |
Also, yes we can use that option in keyv |
I am thinking for backwards compatibility we keep have |
Can you update the Redis README with this new option and examples? |
@jaredwray docs added. Please take a look. Thanks! |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)