Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis - adding in testing on delete when not using redis sets #920

Merged

Conversation

jaredwray
Copy link
Owner

@jaredwray jaredwray commented Sep 17, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
redis - adding in testing on delete when not using redis sets

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.11% 🎉

Comparison is base (cbe367c) 99.88% compared to head (fcffb55) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #920      +/-   ##
===========================================
+ Coverage   99.88%   100.00%   +0.11%     
===========================================
  Files          22        22              
  Lines        2597      2597              
  Branches      342       343       +1     
===========================================
+ Hits         2594      2597       +3     
+ Misses          3         0       -3     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredwray jaredwray merged commit 103faa7 into main Sep 17, 2023
@jaredwray jaredwray deleted the redis---adding-in-testing-on-delete-when-not-using-redis-sets branch September 17, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant