feat: [GH-910] Switch to use Redis UNLINK instead of DEL #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In @keyv/redis, modified the delete() and clear() functions to use UNLINK instead of DEL to improve performance. DEL is blocking and can take longer the larger the key size, whereas UNLINK is non-blocking and perform the operation in O(1) for each key removed regardless of its size.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2597 2597
Branches 343 343
=========================================
Hits 2597 2597
☔ View full report in Codecov by Sentry. |
|
@HishamAli81 - Thanks so much and this has been included. It should go live in the next 2-3 weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In @keyv/redis, modified the delete() and clear() functions to use UNLINK instead of DEL to improve performance.
DEL is blocking and can take longer the larger the key size, whereas UNLINK is non-blocking and perform the operation in O(1) for each key removed regardless of its size.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? feature