Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql - moving to using query instead of execute #923

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

jaredwray
Copy link
Owner

@jaredwray jaredwray commented Sep 25, 2023

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
mysql - moving to using query instead of execute

This is based on the following issue: #170

@banianxd and @Jeffthedevlol FYI. - One thing that would be great is if we could validate with a unit test that this fixes the issue.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fb3cf0d) 100.00% compared to head (3ccb02c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #923   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2597      2597           
  Branches       343       343           
=========================================
  Hits          2597      2597           
Files Changed Coverage Δ
packages/mysql/src/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredwray jaredwray merged commit 1735a32 into main Sep 25, 2023
@jaredwray jaredwray deleted the mysql---moving-to-using-query-instead-of-execute branch September 25, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant