Skip to content

Commit

Permalink
build(api-markdown-documenter): Depend on eslint-config-fluid via f…
Browse files Browse the repository at this point in the history
…ile dependency (microsoft#18799)

Allows the package to always use the latest and greatest, without
needing to publish a new version of the lint config package and install
it. Also makes testing changes in the config package easier. If we like
this pattern, this will be the first such PR of potentially many :)

Also updates code to address new linter rules
  • Loading branch information
Josmithr authored Dec 14, 2023
1 parent 7b6eb98 commit 9284290
Show file tree
Hide file tree
Showing 73 changed files with 1,197 additions and 948 deletions.
7 changes: 7 additions & 0 deletions tools/api-markdown-documenter/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ module.exports = {
project: ["./tsconfig.json"],
},
rules: {
// Rule is reported in a lot of places where it would be invalid to follow the suggested pattern
"@typescript-eslint/class-literal-property-style": "off",

// Comparing general input strings against system-known values (via enums) is used commonly to support
// extensibility.
"@typescript-eslint/no-unsafe-enum-comparison": "off",

/**
* This package utilizes internals of api-documenter that are not exported by the package root.
*
Expand Down
4 changes: 2 additions & 2 deletions tools/api-markdown-documenter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"@fluid-tools/markdown-magic": "file:../markdown-magic",
"@fluidframework/build-common": "^2.0.3",
"@fluidframework/build-tools": "^0.26.1",
"@fluidframework/eslint-config-fluid": "^2.0.0",
"@fluidframework/eslint-config-fluid": "file:../../common/build/eslint-config-fluid",
"@fluidframework/mocha-test-setup": "~2.0.0-internal.6.2.0",
"@microsoft/api-extractor": "^7.38.3",
"@types/chai": "^4.3.4",
Expand All @@ -84,7 +84,7 @@
"copyfiles": "^2.4.1",
"cross-env": "^7.0.3",
"dir-compare": "^4.0.0",
"eslint": "~8.6.0",
"eslint": "~8.55.0",
"eslint-plugin-chai-expect": "^3.0.0",
"eslint-plugin-chai-friendly": "^0.7.2",
"good-fences": "^1.2.0",
Expand Down
Loading

0 comments on commit 9284290

Please sign in to comment.